Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loader contract being called via proxy #3122

Merged
merged 5 commits into from
Sep 6, 2024
Merged

fix: loader contract being called via proxy #3122

merged 5 commits into from
Sep 6, 2024

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Sep 6, 2024 •
edited
Loading

Release notes

In this release, we:

  • Fixed an issue where you couldn't call a loader contract via a proxy contract

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@danielbate danielbate added the bug Issue is a bug label Sep 6, 2024
@danielbate danielbate self-assigned this Sep 6, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 11:31am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 11:31am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 6, 2024 11:31am

@danielbate danielbate marked this pull request as ready for review September 6, 2024 11:13
Torres-ssf
Torres-ssf previously approved these changes Sep 6, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Coverage Report:

Lines Branches Functions Statements
79.37%(+0%) 72.11%(-0.04%) 77.73%(+0%) 79.43%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)		 76.71%
(-1.37%)		 84%
(+0%)		 88.81%
(+0%)

@arboleya
Copy link
Member

arboleya commented Sep 6, 2024

🚢

@danielbate danielbate merged commit e9ad8d0 into master Sep 6, 2024
23 checks passed
@danielbate danielbate deleted the db/fix/proxy-contract-call branch September 6, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@danielbate danielbate

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling a loader contract behind a proxy results in BlobNotFound
4 participants
@danielbate @arboleya @petertonysmith94 @Torres-ssf