-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: deprecate FUEL_NETWORK_URL
and LOCAL_NETWORK_URL
#2915
Merged
petertonysmith94
merged 77 commits into
master
from
ps/chore/deprecate-fuel-network-url-and-local
Aug 15, 2024
Merged
chore!: deprecate FUEL_NETWORK_URL
and LOCAL_NETWORK_URL
#2915
petertonysmith94
merged 77 commits into
master
from
ps/chore/deprecate-fuel-network-url-and-local
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es' of https://github.com/FuelLabs/fuels-ts into ps/chore/deprecate-fuel-network-url-and-local
Nice spot 2c5678a |
Torres-ssf
previously approved these changes
Aug 15, 2024
Base automatically changed from
mc/chore/integrate-launch-test-node-in-remaining-packages
to
master
August 15, 2024 11:26
petertonysmith94
dismissed
Torres-ssf’s stale review
August 15, 2024 11:26
The base branch was changed.
…/chore/deprecate-fuel-network-url-and-local
petertonysmith94
changed the title
chore: deprecate
chore!: deprecate Aug 15, 2024
FUEL_NETWORK_URL
and LOCAL_NETWORK_URL
FUEL_NETWORK_URL
and LOCAL_NETWORK_URL
danielbate
approved these changes
Aug 15, 2024
Torres-ssf
approved these changes
Aug 15, 2024
arboleya
approved these changes
Aug 15, 2024
arboleya
dismissed
maschad’s stale review
August 15, 2024 19:10
Stale - conversation has been resolved.
arboleya
changed the title
chore!: deprecate
chore!: remove Aug 15, 2024
FUEL_NETWORK_URL
and LOCAL_NETWORK_URL
FUEL_NETWORK_URL
and LOCAL_NETWORK_URL
Coverage Report:
Changed Files:Coverage values did not change👌. |
arboleya
changed the title
chore!: remove
chore!: deprecate Aug 15, 2024
FUEL_NETWORK_URL
and LOCAL_NETWORK_URL
FUEL_NETWORK_URL
and LOCAL_NETWORK_URL
petertonysmith94
deleted the
ps/chore/deprecate-fuel-network-url-and-local
branch
August 15, 2024 19:57
maschad
added a commit
that referenced
this pull request
Aug 21, 2024
* refactor: integrated launchTestNode in remaining files * docs: update changeset * test: integrated launchTestNode into all tests excluding doc-snippets * wip * test: refactored many tests in docs-snippets * test: skipping currently failing test suites for ci tests * docs: add changeset * deps: update dependencies * deps: remove cyclical dependency * deps: updated dependencies to use setupTestWallet for now * fix: add error handling for in memory store historical view issues * test: enable browser for demo-fuels index test * docs: added comments about typegen contract call mismatches * revert error supression on provider * test: increasing block production time * test: browser test adjusments * test: browser test adjustments * test: update provider test case for snippets * chore: refactor to use new typegen types * linting * chore: resolve issue with account tests * chore: undo create-fuels.js change * chore: update poa-interval-period * chore: update querying chain docs tests * test: update FUEL_CORE compatability tests * linting fixes * docs: use custom port for launchTestNode * docs: update docs with PR feedback * chore: remove unused testing utilities * chore: more PR feedback refactors * ci: update CI workflow test scripts * ci: update workflow steps * test: update tests to spin up temp nodes in setup * linting * docs: update changesets Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk> * chore: update variable assignment Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk> * docs: update imports Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk> * chore: pr feedback changes * docs: re-introduce testing wallets docs (#2635) Co-authored-by: Anderson Arboleya <anderson@arboleya.me> * chore: update changesets + feedback * ci: remove unnecessary clean step * chore: deprecated urls * chore: changeset * docs: update contributing docs * chore: update test asset IDs * Update network url * chore: refactor account tests to use helper * chore: pr feedback * docs: update changesets * docs: update changeset to breaking * docs: remove unnecessary updates from changeset * chore: removed `FUEL_NETWORK_URL` env * chore: updated pvt key envs * chore: changeset --------- Co-authored-by: chad <chad.nehemiah94@gmail.com> Co-authored-by: Sérgio Torres <30977845+Torres-ssf@users.noreply.github.com> Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FUEL_NETWORK_URL
andLOCAL_NETWORK_URL
#2644Release notes
In this release, we:
FUEL_NETWORK_URL
andLOCAL_NETWORK_URL
constantsBreaking Changes
Removed
FUEL_NETWORK_URL
constant.Removed
LOCAL_NETWORK_URL
constant.Checklist
tests
to prove my changesdocs