Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: deprecate FUEL_NETWORK_URL and LOCAL_NETWORK_URL #2915

Merged
merged 77 commits into from
Aug 15, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Aug 12, 2024

Release notes

In this release, we:

  • Removed FUEL_NETWORK_URL and LOCAL_NETWORK_URL constants

Breaking Changes

Removed FUEL_NETWORK_URL constant.

// before
import { FUEL_NETWORK_URL } from 'fuels';

const provider = await Provider.create(FUEL_NETWORK_URL);
// after
const provider = await Provider.create('https://127.0.0.1:4000/v1/graphql');

Removed LOCAL_NETWORK_URL constant.

// before
import { LOCAL_NETWORK_URL } from 'fuels';

const provider = await Provider.create(LOCAL_NETWORK_URL);
// after
const provider = await Provider.create('https://127.0.0.1:4000/v1/graphql');

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@petertonysmith94
Copy link
Contributor Author

Also we should remove it from the .env.example and update the CONTRIBUTING docs accordingly

Nice spot 2c5678a

Torres-ssf
Torres-ssf previously approved these changes Aug 15, 2024
Base automatically changed from mc/chore/integrate-launch-test-node-in-remaining-packages to master August 15, 2024 11:26
@petertonysmith94 petertonysmith94 dismissed Torres-ssf’s stale review August 15, 2024 11:26

The base branch was changed.

…/chore/deprecate-fuel-network-url-and-local
@petertonysmith94 petertonysmith94 changed the title chore: deprecate FUEL_NETWORK_URL and LOCAL_NETWORK_URL chore!: deprecate FUEL_NETWORK_URL and LOCAL_NETWORK_URL Aug 15, 2024
@petertonysmith94 petertonysmith94 enabled auto-merge (squash) August 15, 2024 16:26
@arboleya arboleya dismissed maschad’s stale review August 15, 2024 19:10

Stale - conversation has been resolved.

@arboleya arboleya changed the title chore!: deprecate FUEL_NETWORK_URL and LOCAL_NETWORK_URL chore!: remove FUEL_NETWORK_URL and LOCAL_NETWORK_URL Aug 15, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.07%(+0%) 71.41%(-0.02%) 77.28%(+0%) 79.21%(+0%)
Changed Files:

Coverage values did not change👌.

@arboleya arboleya changed the title chore!: remove FUEL_NETWORK_URL and LOCAL_NETWORK_URL chore!: deprecate FUEL_NETWORK_URL and LOCAL_NETWORK_URL Aug 15, 2024
@petertonysmith94 petertonysmith94 merged commit 56018e3 into master Aug 15, 2024
36 of 40 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/deprecate-fuel-network-url-and-local branch August 15, 2024 19:57
maschad added a commit that referenced this pull request Aug 21, 2024
* refactor: integrated launchTestNode in remaining files

* docs: update changeset

* test: integrated launchTestNode into all tests excluding doc-snippets

* wip

* test: refactored many tests in docs-snippets

* test: skipping currently failing test suites for ci tests

* docs: add changeset

* deps: update dependencies

* deps: remove cyclical dependency

* deps: updated dependencies to use setupTestWallet for now

* fix: add error handling for in memory store historical view issues

* test: enable browser for demo-fuels index test

* docs: added comments about typegen contract call mismatches

* revert error supression on provider

* test: increasing block production time

* test: browser test adjusments

* test: browser test adjustments

* test: update provider test case for snippets

* chore: refactor to use new typegen types

* linting

* chore: resolve issue with account tests

* chore: undo create-fuels.js change

* chore: update poa-interval-period

* chore: update querying chain docs tests

* test: update FUEL_CORE compatability tests

* linting fixes

* docs: use custom port for launchTestNode

* docs: update docs with PR feedback

* chore: remove unused testing utilities

* chore: more PR feedback refactors

* ci: update CI workflow test scripts

* ci: update workflow steps

* test: update tests to spin up temp nodes in setup

* linting

* docs: update changesets

Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>

* chore: update variable assignment

Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>

* docs: update imports

Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>

* chore: pr feedback changes

* docs: re-introduce testing wallets docs (#2635)

Co-authored-by: Anderson Arboleya <anderson@arboleya.me>

* chore: update changesets + feedback

* ci: remove unnecessary clean step

* chore: deprecated urls

* chore: changeset

* docs: update contributing docs

* chore: update test asset IDs

* Update network url

* chore: refactor account tests to use helper

* chore: pr feedback

* docs: update changesets

* docs: update changeset to breaking

* docs: remove unnecessary updates from changeset

* chore: removed `FUEL_NETWORK_URL` env

* chore: updated pvt key envs

* chore: changeset

---------

Co-authored-by: chad <chad.nehemiah94@gmail.com>
Co-authored-by: Sérgio Torres <30977845+Torres-ssf@users.noreply.github.com>
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider deprecating FUEL_NETWORK_URL and LOCAL_NETWORK_URL
5 participants