-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add isReadOnly
helper for functions
#2008
Conversation
apps/docs-snippets/src/guide/contracts/is-function-readonly.test.ts
Outdated
Show resolved
Hide resolved
apps/docs-snippets/src/guide/contracts/is-function-readonly.test.ts
Outdated
Show resolved
Hide resolved
@petertonysmith94 @danielbate I've improved the API so that people don't have to pass in arguments to the function just to check if it's read-only or not. |
Co-authored-by: Daniel Bate <djbate23@gmail.com>
…ls-ts into dp/function-readonly-helper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've left some suggestions around wording in the docs.
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Coverage Report:
Changed Files:
|
Summary
This PR adds a new helper called
isReadOnly
to theInvokeFunction
type that helps users identify if a given function is read-only or not.Usage
Closes #1931