Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure policies are respected #1423

Merged
merged 8 commits into from
Jun 13, 2024
Merged

Conversation

MujkicA
Copy link
Contributor

@MujkicA MujkicA commented Jun 13, 2024

Ensures that set gas limit and max fee policies take precedence over estimated values.

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@MujkicA MujkicA marked this pull request as ready for review June 13, 2024 11:02
@MujkicA MujkicA requested a review from a team June 13, 2024 11:02
@MujkicA
Copy link
Contributor Author

MujkicA commented Jun 13, 2024

It seems we made gas limit part of the policies even though that doesn't match the specs.

It is convenient to have these knobs all in one place but it might cause confusion if we differ from the underlying system>
It's also a problem when trying to inspect the policies of an executed transaction since we can't easily convert from cores Policy type to our TxPolicies.

We should address this in a future update.

@MujkicA MujkicA self-assigned this Jun 13, 2024
hal3e
hal3e previously approved these changes Jun 13, 2024
hal3e
hal3e previously approved these changes Jun 13, 2024
@MujkicA MujkicA changed the base branch from master to hal3e/non-zero-base-asset-with-tip June 13, 2024 11:59
digorithm
digorithm previously approved these changes Jun 13, 2024
Base automatically changed from hal3e/non-zero-base-asset-with-tip to master June 13, 2024 14:24
@digorithm digorithm dismissed stale reviews from hal3e and themself June 13, 2024 14:24

The base branch was changed.

@MujkicA MujkicA enabled auto-merge (squash) June 13, 2024 14:36
@digorithm digorithm disabled auto-merge June 13, 2024 14:39
@digorithm digorithm merged commit 960cfc2 into master Jun 13, 2024
44 checks passed
@digorithm digorithm deleted the feature/policies-are-respected branch June 13, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants