Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch the default values for the transaction from the network instead of hardcoding #1113

Closed
xgreenx opened this issue Aug 29, 2023 · 1 comment · Fixed by #1121
Closed

Fetch the default values for the transaction from the network instead of hardcoding #1113

xgreenx opened this issue Aug 29, 2023 · 1 comment · Fixed by #1121
Assignees
@MujkicA

Comments

@xgreenx
Copy link
Contributor

xgreenx commented Aug 29, 2023

Fetch the default values for the transaction from the network endpoint instead of hardcoding them in the code directly.

As an example, the current default value is more than allowed by beta 4, and it causes errors like:

>>> forc deploy --node-url http://beta-4.fuel.network/graphql --gas-price 1 
Error: Decode error: Custom { kind: Other, error: "Response errors; TransactionGasLimit" }
@MujkicA MujkicA self-assigned this Aug 31, 2023
@MujkicA MujkicA mentioned this issue Sep 5, 2023
Merged
6 tasks
MujkicA added a commit that referenced this issue Sep 27, 2023
@MujkicA @hal3e
feat: pull tx param defaults from network (#1121)
f996863 
Closes #1113

Bundles relevant NodeInfo and ChainInfo field to NetworkInfo so that it can be provided to a tx builder. The builder is then able to use default values for unset tx parameters.


---------

Co-authored-by: hal3e <git@hal3e.io>
hal3e added a commit that referenced this issue Oct 3, 2023
@MujkicA @hal3e
feat: pull tx param defaults from network (#1121)
9ae7c54 
Closes #1113

Bundles relevant NodeInfo and ChainInfo field to NetworkInfo so that it can be provided to a tx builder. The builder is then able to use default values for unset tx parameters.


---------

Co-authored-by: hal3e <git@hal3e.io>
@digorithm digorithm reopened this Oct 3, 2023
@hal3e
Copy link
Contributor

hal3e commented Oct 4, 2023

This issue was done in: #1121.

@hal3e hal3e closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MujkicA MujkicA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pull tx param defaults from network FuelLabs/fuels-rs
4 participants
@digorithm @xgreenx @MujkicA @hal3e