Remove profiler #914
Merged
Remove profiler #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
added
breaking
Dentosal
requested review from
xgreenx,
MitchTurner and
Voxelot
as code owners
MitchTurner
reviewed
Feb 18, 2025
| @@ -52,7 +51,7 @@ fn test_load_contract_in_script() -> IoResult<(), MemoryStorageError> { | |||
| context: &Context::Script { | |||
| block_height: Default::default(), | |||
| }, | |||
| profiler: &mut Profiler::default(), | |||
|
|
|||
| @@ -111,7 +108,7 @@ fn test_load_contract_in_call() -> IoResult<(), MemoryStorageError> { | |||
| context: &Context::Call { | |||
| block_height: Default::default(), | |||
| }, | |||
| profiler: &mut Profiler::default(), | |||
|
|
|||
| @@ -134,17 +127,15 @@ fn test_code_root_contract_not_found() { | |||
| memory: &mut memory, | |||
| storage: &storage, | |||
| gas_cost, | |||
| profiler: &mut Default::default(), | |||
|
|
|||
| @@ -184,17 +174,15 @@ fn test_code_root_contract_not_in_inputs() { | |||
| memory: &mut memory, | |||
| storage: &storage, | |||
| gas_cost, | |||
| profiler: &mut Default::default(), | |||
|
|
|||
| @@ -143,7 +143,7 @@ fn test_mint( | |||
| context: &context, | |||
| receipts: &mut receipts, | |||
| memory: &mut memory, | |||
| profiler: &mut Profiler::default(), | |||
|
|
|||
| @@ -213,7 +209,7 @@ struct TransferCtx<'vm, S, Tx> { | |||
| context: &'vm Context, | |||
| balances: &'vm mut RuntimeBalances, | |||
| receipts: &'vm mut ReceiptsCtx, | |||
| profiler: &'vm mut Profiler, | |||
|
|
|||
| @@ -108,7 +108,7 @@ where | |||
| context: self.context, | |||
| balances: self.balances, | |||
| panic_context: self.panic_context, | |||
| profiler: self.profiler, | |||
|
|
|||
| @@ -198,7 +198,7 @@ where | |||
| context: self.context, | |||
| balances: self.balances, | |||
| panic_context: self.panic_context, | |||
| profiler: self.profiler, | |||
|
|
|||
Comment on lines
-324
to
-326
| pub(crate) fn contract_id(&self) -> Option<ContractId> { | ||
| self.frames.last().map(|frame| *frame.to()) | ||
| } |
There was a problem hiding this comment.
It was used only for debugger=)
Comment on lines
-1216
to
-1219
| pub current_contract: Option<ContractId>, | ||
| pub cgas: RegMut<'vm, CGAS>, | ||
| pub ggas: RegMut<'vm, GGAS>, | ||
| pub is: Reg<'vm, IS>, |
There was a problem hiding this comment.
Why are current_contract and is removed?
xgreenx
approved these changes
Feb 18, 2025
Comment on lines
-324
to
-326
| pub(crate) fn contract_id(&self) -> Option<ContractId> { | ||
| self.frames.last().map(|frame| *frame.to()) | ||
| } |
There was a problem hiding this comment.
It was used only for debugger=)
Comment on lines
-1216
to
-1219
| pub current_contract: Option<ContractId>, | ||
| pub cgas: RegMut<'vm, CGAS>, | ||
| pub ggas: RegMut<'vm, GGAS>, | ||
| pub is: Reg<'vm, IS>, |
Voxelot
approved these changes
Feb 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody uses the profiler. The profiler pollutes gas charging code. The profiler hurts performance. The superset of this functionality is already available with the debugger. After disussing with @xgreenx, we deemed that removing the profiler is the way to go.
This is a breaking change. I'm quite certain nobody is using this, though, and the replacement is already available.
Since this is supposed to improve benchmarks, we probably want to update gas costs. The effect should be quite even betweeen all opcodes though.
Checklist
Before requesting review