Compare nonce instead of message id of inputs to catch duplicates

[AurelienFT]

Comparing the nonce of two messages inputs if enough to decide if they are duplicated or not. Previously we were computing the message_id now we avoid this computation and only compare the nonce.

It requires us to change the error variant to include nonce instead of message_id. Because the type of the content has change it's already breaking and so we can change the name also to match this type.

Breaking

Before

enum ValidityError {
  DuplicateMessageInputId {
        message_id: MessageId,
  },
  ...
}

After

enum ValidityError {
  DuplicateInputNonce {
        nonce: Nonce,
  },
  ...
}

Checklist

• Breaking changes are clearly marked as such in the PR description and changelog
• New behavior is reflected in tests
• If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
• The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

• I have reviewed the code myself
• I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

• Rust SDK

[rafal-ch]

LGTM 👍

[rafal-ch]

Out of curiosity, do you know what's the purpose of MessageId?

[AurelienFT]

Out of curiosity, do you know what's the purpose of MessageId?

I think it's use to distinguish each message and have a unique id for all of them across the network such as txid or coin id. Detailed spec if needed : https://github.com/FuelLabs/fuel-specs/blob/cca2e8cd2e475263c909cb902620b5ff143713ec/src/identifiers/utxo-id.md#message-id