-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SecretKey): remove Default implementation #845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add a default implementation under the test-helpers
and rand
features. In this case in tests we can generate them easily
addressed in 8a34cd6 |
Fixes #830
Description
Deriving
Default
for theSecretKey
doesn't exactly make too much sense given that we don't use it anywhere in this codebase, and the fact thatk256::SecretKey
throws an error if the provided byte slice is 0 -We could have a default impl by using rng, but we should expect consumers of this library to use their own impl, or use
SecretKey::random()
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]