Add fn add_fee_input() and make fn add_random_fee_input() truly random
#829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
approved these changes
Sep 17, 2024
MitchTurner
approved these changes
Sep 17, 2024
acerone85
reviewed
Sep 17, 2024
| } | ||
|
|
||
| #[cfg(feature = "rand")] | ||
| pub fn add_fee_input(&mut self) -> &mut Self { |
There was a problem hiding this comment.
can this be simply
self.add_rnadom_fee_input(rand::rngs::StdRng::seed_from_u64(2322u64))?
There was a problem hiding this comment.
Yes, that would work. Since it's not critical, I'll consider updating this part with next PR to fuel-vm.
|
one minor comment, but otherwise LGTM |
|
@rafal-ch This change is breaking, so it should modify the changelog |
1 task
I created a follow-up PR: #836 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
add_random_fee_input()wasn't actually producing a random input, which was confusing. This PR:add_fee_input()which is an equivalent to the former version ofadd_random_fee_input()add_random_fee_input()to accept anrngand provide truly random fee inputFor compatibility reasons, all tests that were previously using
add_random_fee_input()were modified to useadd_fee_input().This change should make the test code more explicit and make it easier to create random transactions in test code.
Before requesting review
Follow-up draft PR in
fuel-core: FuelLabs/fuel-core#2211