Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge for max length in LDC opcode #776

Merged
merged 5 commits into from
Jun 16, 2024

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Jun 16, 2024

If the contract is small but the length is huge, we will undercharge the user because we still need to allocate the stack.

Before requesting review

  • I have reviewed the code myself

@xgreenx xgreenx requested review from Voxelot and a team June 16, 2024 08:29
@xgreenx xgreenx self-assigned this Jun 16, 2024
@xgreenx xgreenx closed this Jun 16, 2024
@xgreenx xgreenx reopened this Jun 16, 2024
@xgreenx xgreenx changed the title Feature/charge for max length ldc Charge for max length in LDC opcode Jun 16, 2024
@xgreenx xgreenx added this pull request to the merge queue Jun 16, 2024
Merged via the queue into master with commit 7447144 Jun 16, 2024
39 checks passed
@xgreenx xgreenx deleted the feature/charge-for-max-length-ldc branch June 16, 2024 17:01
@xgreenx xgreenx mentioned this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants