Take into account spent gas during synchronous predicates estimation #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
reviewed
Jun 15, 2024
| let result = transaction.estimate_predicates(¶ms, MemoryInstance::new()); | ||
|
|
||
| // Then | ||
| assert_eq!(Ok(()), result); |
There was a problem hiding this comment.
if the estimation runs out of gas due to each predicate running an infinite loop, why is this an Ok(())?
There was a problem hiding this comment.
It was done a long time ago to allow estimate predicates even if they return false. For cases when signature incorrect and predicate fails
I also don't like it=D I was thinking of modifying the code and returning an error in all cases except false predicate. But it will change how estimation works, so I decided not to include it in this PR.
There was a problem hiding this comment.
Ok - this seems odd but makes sense given the context. If predicates are invalid the estimation should return an error imo.
Voxelot
approved these changes
Jun 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #756
The
fuel-corealready uses synchronous predicate estimation, so we don't need any other changes.Before requesting review