Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the correct gas units for wdop and wqop #765

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Jun 15, 2024

closes #759

WDOP and WQOP used the incorrect gas units. WDOP will increase from 2 to 3, while WQCP will stay at 3.

This may affect the Rust SDK which sometimes run the VM locally for predicate estimation.

Testnet gas schedule for reference: https://github.com/FuelLabs/chain-configuration/blob/master/ignition/chain_config.json

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@Voxelot Voxelot requested review from Dentosal and xgreenx June 15, 2024 01:45
@Voxelot Voxelot added the breaking A breaking api change label Jun 15, 2024
@Voxelot Voxelot self-assigned this Jun 15, 2024
@xgreenx xgreenx added this pull request to the merge queue Jun 15, 2024
Merged via the queue into master with commit e041eff Jun 15, 2024
39 checks passed
@xgreenx xgreenx deleted the bug/wdop-wqop-gas branch June 15, 2024 08:35
@xgreenx xgreenx mentioned this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking api change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect gas charged for wdop / wqop operations
2 participants