Fix a bug in CCP instruction #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
added
bug
Dentosal
commented
Jun 11, 2024
fuel-vm/src/tests/blockchain.rs
Outdated
Comment on lines
1182
to
1184
| /// TODO: remove this test after review, the one above covers it better | ||
| #[test] | ||
| fn code_copy_ownership_overflow_poc() { |
There was a problem hiding this comment.
This reproction test case is from the audit report, and kept here for the review. It should be removed before merging.
xgreenx
previously approved these changes
Jun 12, 2024
xgreenx
approved these changes
Jun 12, 2024
|
|
||
| let src_end = src_offset.saturating_add(range.len()).min(src.len()); | ||
| let data = src.get(src_offset..src_end).unwrap_or_default(); | ||
| let (r_data, r_zero) = range.split_at_offset(data.len()); | ||
|
|
||
| memory |
There was a problem hiding this comment.
Hmm, maybe we need to revisit all places where we use write_noownerchecks, maybe we don't need it anymore and we can just pass OwnershipRegisters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCP instruction was not checking for ownership properly. This PR fixes the bug, and refactors the code a bit so that similar issues cannot occur again as easily.
Checklist
Before requesting review