Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero $flag on call #743

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Zero $flag on call #743

merged 3 commits into from
Jun 3, 2024

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Jun 3, 2024 •
edited
Loading

Spec PR: FuelLabs/fuel-specs#585

Called contracts shouldn't inherit the $flag register.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

@Dentosal Dentosal added the breaking A breaking api change label Jun 3, 2024
@Dentosal Dentosal self-assigned this Jun 3, 2024
@Dentosal Dentosal mentioned this pull request Jun 3, 2024
Merged
1 task
@Dentosal Dentosal added the fuel-vm Related to the `fuel-vm` crate. label Jun 3, 2024
@Dentosal Dentosal marked this pull request as ready for review June 3, 2024 07:21
@Dentosal Dentosal requested a review from a team June 3, 2024 07:21
Dentosal added a commit to FuelLabs/fuel-specs that referenced this pull request Jun 3, 2024
@Dentosal
Zero $flag on call (#585)
7637bef 
VM PR: FuelLabs/fuel-vm#743

Called contracts shouldn't inherit the `$flag` register.

### Before requesting review
- [x] I have reviewed the code myself
@Dentosal Dentosal added this pull request to the merge queue Jun 3, 2024
Merged via the queue into master with commit e568069 Jun 3, 2024
38 checks passed
@Dentosal Dentosal deleted the dento/zero-flag-on-call branch June 3, 2024 08:05
@xgreenx xgreenx mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

Assignees

@Dentosal Dentosal

Labels
breaking A breaking api change fuel-vm Related to the `fuel-vm` crate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dentosal @xgreenx