-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advanced fuzzer (#724) #733
Conversation
Sounds good, feel free to do the same with the others :) As I can not really commit to this PR I'm checking this off my todo for now. I think the other PR is mainly failing because external PRs don't have access to secrets, which is good. Both PRs need a cargo format. |
2a53871
to
33bcd3b
Compare
* Add initial fuzz files * Fix original fuzz test * Add byte-based script functions back for fuzzing * Disable some errors for fuzzing * Fix new fuzz test due to changes in fuel-vm * Remove unused target * Add readme
33bcd3b
to
c79a5a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!=) I can't approve since I created this PR initially=D
Nice, I'll approve in your place=) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, added some minor comments :)
PR currently blocked on #815
Closes FuelLabs/fuel-core#1443
Related #718
The original PR. I moved the change to our codebase to see how CI works, plus it allows us to commit changes as well. Huge thanks to the @maxammann for finalizing the PR!
Edit (@netrome): I have done a few modifications on the original PR to make this ready to merge.
grammar_aware
fuzz target.libafl
andlibfuzzer
feature flags to toggle between the LibAFL and LibFuzzer fuzzers, without having to manually comment out dependencies, as the original PR required.sign
function. #815 to further investigate and resolve this.Before requesting review