Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced fuzzer (#724) #733

Merged
merged 34 commits into from
Sep 10, 2024
Merged

Add advanced fuzzer (#724) #733

merged 34 commits into from
Sep 10, 2024

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented May 13, 2024

PR currently blocked on #815

Closes FuelLabs/fuel-core#1443
Related #718

The original PR. I moved the change to our codebase to see how CI works, plus it allows us to commit changes as well. Huge thanks to the @maxammann for finalizing the PR!

Edit (@netrome): I have done a few modifications on the original PR to make this ready to merge.

  • Cleaned up unused code and clippy errors so the PR passes CI.
  • Removed the outdated and broken grammar_aware fuzz target.
  • Updated the README.md with instructions for how to generate a corpus, run the fuzzer, generate code coverage reports.
  • Added an example initial corpus so people don't have to generate a corpus from scratch to run the fuzzer.
  • Added the libafl and libfuzzer feature flags to toggle between the LibAFL and LibFuzzer fuzzers, without having to manually comment out dependencies, as the original PR required.
  • Did an initial investigation of discovered crashes, and created Investigation: Possibility of generating non-normalized signatures in sign function. #815 to further investigate and resolve this.

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@xgreenx xgreenx assigned xgreenx and unassigned xgreenx May 13, 2024
@maxammann
Copy link
Contributor

Sounds good, feel free to do the same with the others :) As I can not really commit to this PR I'm checking this off my todo for now.

I think the other PR is mainly failing because external PRs don't have access to secrets, which is good.

Both PRs need a cargo format.

@xgreenx xgreenx assigned netrome and unassigned xgreenx Aug 26, 2024
@netrome netrome force-pushed the feature/tob-fuzzer branch 2 times, most recently from 2a53871 to 33bcd3b Compare September 5, 2024 19:16
maxammann and others added 4 commits September 5, 2024 21:17
* Add initial fuzz files

* Fix original fuzz test

* Add byte-based script functions back for fuzzing

* Disable some errors for fuzzing

* Fix new fuzz test due to changes in fuel-vm

* Remove unused target

* Add readme
@netrome netrome added the no changelog Skips the CI changelog check label Sep 5, 2024
Copy link
Collaborator Author

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!=) I can't approve since I created this PR initially=D

@netrome
Copy link
Contributor

netrome commented Sep 10, 2024

LGTM!=) I can't approve since I created this PR initially=D

Nice, I'll approve in your place=)

@netrome netrome self-requested a review September 10, 2024 09:06
netrome
netrome previously approved these changes Sep 10, 2024
Copy link
Member

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, added some minor comments :)

fuel-vm/fuzz/README.md Outdated Show resolved Hide resolved
fuel-vm/fuzz/src/bin/collect.rs Outdated Show resolved Hide resolved
fuel-vm/fuzz/src/bin/seed.rs Outdated Show resolved Hide resolved
fuel-vm/fuzz/src/bin/execute.rs Outdated Show resolved Hide resolved
fuel-vm/fuzz/src/lib.rs Outdated Show resolved Hide resolved
fuel-vm/fuzz/src/lib.rs Outdated Show resolved Hide resolved
@netrome netrome requested a review from rymnc September 10, 2024 12:57
@netrome netrome added this pull request to the merge queue Sep 10, 2024
Merged via the queue into master with commit dfab064 Sep 10, 2024
39 checks passed
@netrome netrome deleted the feature/tob-fuzzer branch September 10, 2024 13:43
@xgreenx xgreenx mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests from ToB
6 participants