Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sum Tree codebase #726

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

bvrooman
Copy link
Contributor

@bvrooman bvrooman commented Apr 22, 2024

Related issues:

  • Untracked

This PR removes the Binary Merkle Sum Tree since it is deprecated and not used. Removing the BMST will reduce the overall codebase complexity and improve readability.

Because this removes public facing types, this is a breaking change. However, it is safe in the context of fuel-core since the BMST was never used.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@bvrooman bvrooman self-assigned this Apr 22, 2024
@bvrooman bvrooman marked this pull request as ready for review April 22, 2024 17:05
@bvrooman bvrooman requested a review from a team April 22, 2024 17:08
@bvrooman bvrooman added this pull request to the merge queue Apr 23, 2024
Merged via the queue into master with commit 15018bd Apr 23, 2024
38 checks passed
@bvrooman bvrooman deleted the bvrooman/chore/remove-sum-tree-code branch April 23, 2024 15:20
@xgreenx xgreenx mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants