-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reshuffled fields Script
and Create
transactions to unify part used by all chargeable transactions
#703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced default `MAX_SIZE` to be 110kb. Reduced default `MAX_CONTRACT_SIZE` to be 100kb.
# Conflicts: # CHANGELOG.md # fuel-tx/src/builder.rs # fuel-tx/src/tests/valid_cases/transaction.rs # fuel-tx/src/transaction/consensus_parameters.rs # fuel-vm/src/checked_transaction.rs # fuel-vm/src/tests/limits.rs # fuel-vm/src/tests/validation.rs
…ed by all chargeable transactions
bvrooman
previously approved these changes
Mar 22, 2024
# Conflicts: # fuel-tx/src/transaction/consensus_parameters.rs # fuel-vm/src/tests/validation.rs
Dentosal
previously approved these changes
Mar 25, 2024
xgreenx
dismissed stale reviews from Dentosal and bvrooman
March 25, 2024 15:57
The base branch was changed.
xgreenx
added a commit
to FuelLabs/fuel-specs
that referenced
this pull request
Mar 26, 2024
Soon, we will add several more transaction variants that are also chargeable. Because of that, I've decided to move unique fields of the transaction to the top while keeping the common part at the end. Implementation part with description of how it can be used FuelLabs/fuel-vm#703 (comment)
Dentosal
approved these changes
Mar 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related specification change: FuelLabs/fuel-specs#562
This change is a preparation for a small refactoring to create a template for chargeable transactions. Any chargeable transaction should contain
inputs
andoutput
for coins,policies
to actually charge the user, andwitnesses
for verifying signatures and any arbitrary data.The template will look like:
Where
Body
is a unique part related to the business logic of the transaction.In the case of the
Script
it is:In the case of the
Create
it is: