Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access to {asset_id,to,amount} fields for Variable and Change outputs #675

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Feb 12, 2024

Closes #650

@Dentosal
Copy link
Member Author

After #678 accessing fields of Output::Variable no longer make sense. Also, as Voxelot pointed out above, Output::Change amount is always zero, so better leave that one out as well.

@Dentosal Dentosal marked this pull request as ready for review February 28, 2024 16:36
@Dentosal Dentosal requested a review from a team February 28, 2024 16:37
@Dentosal Dentosal added breaking A breaking api change fuel-vm Related to the `fuel-vm` crate. labels Feb 28, 2024
@xgreenx xgreenx added this pull request to the merge queue Feb 28, 2024
Merged via the queue into master with commit 3ff9965 Feb 28, 2024
72 of 81 checks passed
@xgreenx xgreenx deleted the dento/gtf-change-fields branch February 28, 2024 16:52
@xgreenx xgreenx mentioned this pull request Feb 29, 2024
bitzoic added a commit to FuelLabs/sway that referenced this pull request Sep 24, 2024
…)` (#6562)

## Description

Support to get the `to` and `asset_id` fields of an `Output::Change`
were added in FuelLabs/fuel-vm#675. The std-lib
now enables this.

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking api change fuel-vm Related to the `fuel-vm` crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should be able to get the AssetId & To for a Change output
3 participants