Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-exhaustive attribute for versionable types #668

Merged
merged 18 commits into from
Jan 30, 2024

Conversation

MitchTurner
Copy link
Member

We decided that the convenience of having these backward compatible isn't worth the security cost of losing type guarantees.

@xgreenx
Copy link
Collaborator

xgreenx commented Jan 30, 2024

It would be nice to revert all changes from https://github.com/FuelLabs/fuel-vm/pull/654/files =)

@MitchTurner MitchTurner requested a review from a team January 30, 2024 22:21
@MitchTurner MitchTurner added this pull request to the merge queue Jan 30, 2024
Merged via the queue into master with commit 766e6b8 Jan 30, 2024
37 checks passed
@MitchTurner MitchTurner deleted the remove-non-exhaustive branch January 30, 2024 22:36
@xgreenx xgreenx mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants