Memory write xor execute #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
added
breaking
xgreenx
previously approved these changes
Oct 27, 2023
| 0, // The value is meaningless since fetch was out-of-bounds | ||
| )), | ||
| )?; | ||
| if pc < self.registers[RegId::IS] || pc >= self.registers[RegId::SSP] { |
There was a problem hiding this comment.
I thought about the solution to update all places where we modify $pc. But it also works=)
I don't know how it affects the performance, but we can try to optimize it later=)
There was a problem hiding this comment.
all jmp opcodes use the same inner fn, so it would be an easy place to centralize that logic.
|
Hmm, it is a huge breaking change for any bytecode that doesn't return from the execution=) |
xgreenx
approved these changes
Oct 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #616. Closes #564.
This PR makes attempting to execute opcodes outside
$is..$ssprange panic withMemoryNotExecutableerror. It also separatesErrorFlagintoInvalidFlagsandInvalidInstruction, which make more sense. Then finally it fixes some tests that incorrectly assumed that any of these were equivalent, and some that had even weirder misconceptions.