Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use MerkleRootCalculator when only BMT root is needed #612

Merged
merged 3 commits into from
Oct 23, 2023
Merged

chore: Use MerkleRootCalculator when only BMT root is needed #612

merged 3 commits into from
Oct 23, 2023

Conversation

bvrooman
Copy link
Contributor

@bvrooman bvrooman commented Oct 22, 2023 •
edited
Loading

Related issues:

This PR updates all relevant usages of binary::in_memory::MerkleTree inside fuel-vm to use binary::root_calculator::MerkleRootCalculator for calculating BMT roots.

@bvrooman bvrooman added the no changelog Skips the CI changelog check label Oct 22, 2023
@bvrooman bvrooman self-assigned this Oct 23, 2023
@bvrooman bvrooman marked this pull request as ready for review October 23, 2023 01:31
@bvrooman bvrooman requested a review from a team October 23, 2023 01:31
xgreenx
xgreenx previously approved these changes Oct 23, 2023
View reviewed changes
@xgreenx xgreenx removed the no changelog Skips the CI changelog check label Oct 23, 2023
@xgreenx xgreenx added this pull request to the merge queue Oct 23, 2023
Merged via the queue into master with commit bb99190 Oct 23, 2023
37 checks passed
@xgreenx xgreenx deleted the bvrooman/chore/use-merkle-root-calculator branch October 23, 2023 08:53
@xgreenx xgreenx mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

Assignees

@bvrooman bvrooman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bvrooman @xgreenx