Predicate input validation tests #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
reviewed
Oct 2, 2023
| macro_rules! predicate_input { | ||
| ($predicate:expr) => {{ | ||
| let predicate: Vec<u8> = $predicate.into_iter().collect(); | ||
| let owner = Input::predicate_owner(&predicate, &ChainId::default()); |
There was a problem hiding this comment.
I thought that this issue was related to message_data_predicate and message_coin_predicate inputs=D
There was a problem hiding this comment.
Oops fixed the wrong thing =D. Moving back to a draft so I'll add tests fro those as well.
xgreenx
approved these changes
Oct 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181
Also improves error propagation so that predicate error message better reflects the reason for invalidation. For instance, it now includes the disallowed contract opcode which was not accepted in predicate exection context.