Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace thiserror with derive_more::Display #587

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

Dentosal
Copy link
Member

Follow-up to #582

Replaces thiserror dependency of no_std crates with a core::fmt::Display implementations generated by derive_more crate. This is a breaking change, since we lose std::io::Error trait impls when std feature is enabled.

@Dentosal Dentosal added the breaking A breaking api change label Sep 22, 2023
@Dentosal Dentosal self-assigned this Sep 22, 2023
@Dentosal Dentosal requested review from xgreenx and bvrooman and removed request for xgreenx September 22, 2023 13:08
Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! <3

@Dentosal Dentosal added this pull request to the merge queue Sep 22, 2023
Merged via the queue into master with commit 31ef778 Sep 22, 2023
37 checks passed
@Dentosal Dentosal deleted the dento/error-display-no-thiserror branch September 22, 2023 16:09
@xgreenx xgreenx mentioned this pull request Sep 27, 2023
Dentosal added a commit to FuelLabs/fuel-core that referenced this pull request Sep 27, 2023
Addresses breaking fuel-vm changes from
FuelLabs/fuel-vm#582,
FuelLabs/fuel-vm#578,
FuelLabs/fuel-vm#588 and
FuelLabs/fuel-vm#587.

Waiting for a new fuel-vm release.

---------

Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
crypto523 added a commit to crypto523/fuel-core that referenced this pull request Oct 7, 2024
Addresses breaking fuel-vm changes from
FuelLabs/fuel-vm#582,
FuelLabs/fuel-vm#578,
FuelLabs/fuel-vm#588 and
FuelLabs/fuel-vm#587.

Waiting for a new fuel-vm release.

---------

Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking api change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants