Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed length input for BMT node_sum #574

Merged
merged 4 commits into from
Aug 29, 2023
Merged

fix: Fixed length input for BMT node_sum #574

merged 4 commits into from
Aug 29, 2023

Conversation

bvrooman
Copy link
Contributor

@bvrooman bvrooman commented Aug 29, 2023 •
edited
Loading

Related issues:

This PR enforces all inputs to the internal node_sum function to be Bytes32.

@bvrooman bvrooman self-assigned this Aug 29, 2023
@bvrooman
Copy link
Contributor Author

bvrooman commented Aug 29, 2023 •
edited
Loading

Blocked by #575 Unblocked

@bvrooman bvrooman marked this pull request as ready for review August 29, 2023 17:48
@bvrooman bvrooman requested a review from a team August 29, 2023 21:08
@xgreenx xgreenx added this pull request to the merge queue Aug 29, 2023
Merged via the queue into master with commit 7f3fd1d Aug 29, 2023
33 checks passed
@xgreenx xgreenx deleted the bvrooman/fix/node-sum-fixed-length-input branch August 29, 2023 23:27
@bvrooman bvrooman mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

Assignees

@bvrooman bvrooman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TOB-FUEL-9: Lack of length validation for leaves in internal node hash calculation
2 participants
@bvrooman @xgreenx