Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove any unchecked arithmetic #552

Closed
wants to merge 6 commits into from
Closed

Remove any unchecked arithmetic #552

wants to merge 6 commits into from

Conversation

MitchTurner
Copy link
Member

@MitchTurner MitchTurner marked this pull request as draft August 18, 2023 20:51
@xgreenx
Copy link
Collaborator

xgreenx commented Aug 24, 2023

Close in favor of #553.

This PR tried to fix the problem for all crates, but it has conflicts with #533. So we decided to go crate by crate to avoid double work/huge conflicts.

@xgreenx xgreenx closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx will be requested when the pull request is marked ready for review xgreenx is a code owner

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal will be requested when the pull request is marked ready for review Dentosal is a code owner

@Voxelot Voxelot Awaiting requested review from Voxelot Voxelot will be requested when the pull request is marked ready for review Voxelot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MitchTurner @xgreenx