Bump dalek version because of RustSec Advisory #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
reviewed
Aug 14, 2023
fuel-vm/Cargo.toml
Outdated
| @@ -36,7 +36,7 @@ tai64 = "4.0" | |||
| thiserror = "1.0" | |||
|
|
|||
| [dev-dependencies] | |||
| ed25519-dalek = "1.0" # TODO: upgrade to 2.0 when it's released, and remove rand below | |||
| ed25519-dalek = "2.0.0" | |||
| ed25519-dalek_old_rand = { package = "rand", version = "0.7.3" } | |||
There was a problem hiding this comment.
Do we still need to use this one?=)
There was a problem hiding this comment.
It has rand_core feature, maybe we can use it isntead
There was a problem hiding this comment.
Yep. That seems to work.
| @@ -15,7 +15,7 @@ borrown = "0.1" | |||
| coins-bip32 = { version = "0.8", default-features = false, optional = true } | |||
| coins-bip39 = { version = "0.8", default-features = false, features = ["english"], optional = true } | |||
| ecdsa = { version = "0.16", default-features = false } | |||
| ed25519-dalek = { version = "1.0", default-features = false, features = ["u64_backend"] } | |||
| ed25519-dalek = { version = "2.0.0", default-features = false } | |||
There was a problem hiding this comment.
Is u64_backend a default behavior right now?
There was a problem hiding this comment.
I couldn't see what happened to it, so I figured I'd rely on the the compiler to tell me.
xgreenx
approved these changes
Aug 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.