Some additional test to verify ecrecovery with TxId and coin witness
#495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
approved these changes
Jun 16, 2023
| op::gtf_args(0x22, 0x00, GTFArgs::WitnessData), | ||
| // TxId is stored in the first 32 bytes of the memory | ||
| // Store it into register 0x23 | ||
| op::movi(0x23, 0), |
There was a problem hiding this comment.
Nit: registers are zeroed already on initialization
| // 0x10 contains the size of the public key = PublicKey::LEN | ||
| op::movi(0x10, PublicKey::LEN as Immediate18), | ||
| op::aloc(0x10), | ||
| op::move_(0x11, RegId::HP), |
There was a problem hiding this comment.
Nit: assigning to a register is not needed, RegId::HP could be used directly in place of 0x11 after this.
|
It is to make the test case more clear=D |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@luizstacio is working on the predicate, and he tried to recover the signer public key from the witness and
TxId. These tests verify the behavior for the script and predicate on thefuel-vmside.