Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement safe arithmetic for blockchain mod #195

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Implement safe arithmetic for blockchain mod #195

merged 3 commits into from
Sep 1, 2022

Conversation

vlopes11
Copy link
Contributor

@vlopes11 vlopes11 commented Aug 16, 2022 •
edited by ghost
Loading

Addresses blockchain.rs for issue #170

@vlopes11 vlopes11 added the enhancement New feature or request label Aug 16, 2022
@vlopes11 vlopes11 requested review from Voxelot, Dentosal, adlerjohn and a user August 16, 2022 17:05
@vlopes11 vlopes11 self-assigned this Aug 16, 2022
@vlopes11 vlopes11 enabled auto-merge (squash) August 16, 2022 17:07
@vlopes11 vlopes11 requested a review from a user August 16, 2022 20:01
@vlopes11 vlopes11 requested a review from adlerjohn August 18, 2022 00:55
adlerjohn
adlerjohn reviewed Aug 18, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, but will defer to client team

@ghost ghost mentioned this pull request Sep 1, 2022
Merged
ghost
ghost approved these changes Sep 1, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested all of these checks in my associated PR, approved

@vlopes11 vlopes11 merged commit 155931a into master Sep 1, 2022
@vlopes11 vlopes11 deleted the vlopes11/safe-arith-blockchain branch September 1, 2022 20:26
ControlCplusControlV pushed a commit that referenced this pull request Nov 24, 2022
@Salka1988
Add contract_id to Receipt::Panic (#195)
ae3e5e4
ControlCplusControlV pushed a commit that referenced this pull request Dec 1, 2022
@Salka1988
Add contract_id to Receipt::Panic (#195)
d43e88c
@mitchmindtree mitchmindtree added the fuel-vm Related to the `fuel-vm` crate. label Dec 9, 2022
xgreenx pushed a commit that referenced this pull request Dec 20, 2022
@Salka1988 @xgreenx
Add contract_id to Receipt::Panic (#195)
e602d25
xgreenx pushed a commit that referenced this pull request Dec 20, 2022
@Salka1988 @xgreenx
Add contract_id to Receipt::Panic (#195)
92d07e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn left review comments

@Voxelot Voxelot Awaiting requested review from Voxelot Voxelot is a code owner

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

Assignees

@vlopes11 vlopes11

Labels
enhancement New feature or request fuel-vm Related to the `fuel-vm` crate.
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlopes11 @adlerjohn @mitchmindtree