Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds concrete types distinction to JSON ABI. #599

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Commits on Jul 16, 2024

  1. Adds concrete types distinction to JSON ABI.

    With the changes proposed in this PR, functions,loggedTypes,
    messagesTypes and configurables will only rely on hash based ids of
    concrete types.
    
    This change is required because types on the types arrays can be
    abstract types, so the hash based ids could not include the generic
    parameters of the concrete types used.
    
    For instance a method with two args, `Option<u64>` and `Option<u32>`,
    would generate two distinct hash based ids based on `sha256("enum std::option::Option<u64>")`
    and `sha256("enum std::option::Option<u32>")`, but there was a single type for Option.
    
    With the proposed changes we can now have multiple hash based ids for
    generic types, while still having access to the same generated types as
    the new `concreteTypes` map easily to the `typesMetadata` (old `types`).
    esdrubal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    882a860 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Applies review changes.

    esdrubal committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    2fa4986 View commit details
    Browse the repository at this point in the history
  2. More review changes.

    esdrubal committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f4b0437 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Configuration menu
    Copy the full SHA
    1aee040 View commit details
    Browse the repository at this point in the history
  2. Fixes typos.

    esdrubal committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    32bb9ba View commit details
    Browse the repository at this point in the history