Add GTF getters for tx bytes size and address #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizstacio
reviewed
Mar 7, 2024
src/fuel-vm/instruction-set.md
Outdated
| @@ -2473,6 +2473,8 @@ Get [fields from the transaction](../tx-format/transaction.md). | |||
| | `GTF_SCRIPT_INPUT_AT_INDEX` | `0x00B` | Memory address of `tx.inputs[$rB]` | | |||
| | `GTF_SCRIPT_OUTPUT_AT_INDEX` | `0x00C` | Memory address of `t.outputs[$rB]` | | |||
| | `GTF_SCRIPT_WITNESS_AT_INDEX` | `0x00D` | Memory address of `tx.witnesses[$rB]` | | |||
| | `GTF_TX_START_ADDRESS` | `0x0A0` | Memory address of the raw transaction bytes | | |||
There was a problem hiding this comment.
Should we remove the address at the end, to follow other gtfs?
xgreenx
reviewed
Mar 7, 2024
src/fuel-vm/instruction-set.md
Outdated
| @@ -2473,6 +2473,8 @@ Get [fields from the transaction](../tx-format/transaction.md). | |||
| | `GTF_SCRIPT_INPUT_AT_INDEX` | `0x00B` | Memory address of `tx.inputs[$rB]` | | |||
| | `GTF_SCRIPT_OUTPUT_AT_INDEX` | `0x00C` | Memory address of `t.outputs[$rB]` | | |||
| | `GTF_SCRIPT_WITNESS_AT_INDEX` | `0x00D` | Memory address of `tx.witnesses[$rB]` | | |||
| | `GTF_TX_START_ADDRESS` | `0x0A0` | Memory address of the raw transaction bytes | | |||
There was a problem hiding this comment.
Maybe we should consider using GM for it. Since it is not TX fields=D Just a thought
src/fuel-vm/instruction-set.md
Outdated
| @@ -2473,6 +2473,8 @@ Get [fields from the transaction](../tx-format/transaction.md). | |||
| | `GTF_SCRIPT_INPUT_AT_INDEX` | `0x00B` | Memory address of `tx.inputs[$rB]` | | |||
| | `GTF_SCRIPT_OUTPUT_AT_INDEX` | `0x00C` | Memory address of `t.outputs[$rB]` | | |||
| | `GTF_SCRIPT_WITNESS_AT_INDEX` | `0x00D` | Memory address of `tx.witnesses[$rB]` | | |||
| | `GTF_TX_START_ADDRESS` | `0x0A0` | Memory address of the raw transaction bytes | | |||
| | `GTF_TX_LENGTH` | `0x0A1` | Length of raw transaction types in memory | | |||
There was a problem hiding this comment.
Why do we want to put size and offset under 0x0A1 and 0x0A0? Maybe it is better to put them at the end
There was a problem hiding this comment.
No real reason. The location just seemed appropriate. I'll move them.
xgreenx
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #554
VM PR: FuelLabs/fuel-vm#692