-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
30ede12
to
949a727
Compare
759329e
to
5c2bffd
Compare
@@ -32,7 +32,8 @@ sha2 = "0.10" | |||
syn = { version = "2.0", features = ["full"] } | |||
|
|||
[dev-dependencies] | |||
fuel-indexer-plugin = { workspace = true } | |||
# This is a workaround to avoid cyclic dependency problems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ra0x3 I'll add a link and a small blurb. The futures
crate had the same issue with publishing with a circular dependency in dev-dependencies
; this addition worked for them due to some of the intricacies of how rustc > 1.40
strips some information from dev-dependencies
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deekerno Yea see stuff like that, with supporting links is super helpful context to have. We can dump that into the Github issue as well 👌🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ra0x3 I decided to keep the comment and link to the issue from the futures
crate that contains their explanation and links to other projects that have used the same workaround. Let me know if that doesn't seem like a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Description
Re-enable TRYBUILD tests.
Testing steps
CI should pass.
Notes
The change to
fuel-indexer-macros
dev-dependencies was taken from this PR from thefutures
crate: rust-lang/futures-rs#2305.