Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

chore: re-enable TRYBUILD tests #1086

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Conversation

deekerno
Copy link
Contributor

@deekerno deekerno commented Jul 11, 2023

Description

Re-enable TRYBUILD tests.

Testing steps

CI should pass.

Notes

The change to fuel-indexer-macros dev-dependencies was taken from this PR from the futures crate: rust-lang/futures-rs#2305.

@deekerno deekerno force-pushed the deekerno/reenable-trybuild-tests branch from 30ede12 to 949a727 Compare July 12, 2023 03:28
@deekerno deekerno force-pushed the deekerno/reenable-trybuild-tests branch from 759329e to 5c2bffd Compare July 12, 2023 04:39
@deekerno deekerno marked this pull request as ready for review July 12, 2023 05:07
@deekerno deekerno requested a review from ra0x3 as a code owner July 12, 2023 05:07
@ra0x3 ra0x3 requested a review from lostman July 12, 2023 14:28
@@ -32,7 +32,8 @@ sha2 = "0.10"
syn = { version = "2.0", features = ["full"] }

[dev-dependencies]
fuel-indexer-plugin = { workspace = true }
# This is a workaround to avoid cyclic dependency problems
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lostman What do you think of this?

@deekerno Maybe might be better to create a Github issue explaining the background here? We could tag it with "fyi" and link the issue here instead of this comment. Looks harmless to me?

Copy link
Contributor Author

@deekerno deekerno Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ra0x3 I'll add a link and a small blurb. The futures crate had the same issue with publishing with a circular dependency in dev-dependencies; this addition worked for them due to some of the intricacies of how rustc > 1.40 strips some information from dev-dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deekerno Yea see stuff like that, with supporting links is super helpful context to have. We can dump that into the Github issue as well 👌🏽

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ra0x3 I decided to keep the comment and link to the issue from the futures crate that contains their explanation and links to other projects that have used the same workaround. Let me know if that doesn't seem like a good idea.

@deekerno deekerno requested a review from ra0x3 July 12, 2023 15:24
Copy link
Contributor

@ra0x3 ra0x3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@deekerno deekerno merged commit 6834ba6 into develop Jul 12, 2023
@deekerno deekerno deleted the deekerno/reenable-trybuild-tests branch July 12, 2023 16:07
deekerno added a commit that referenced this pull request Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants