Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky test_poa_multiple_producers test #2353

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Conversation

rafal-ch
Copy link
Contributor

This PR disables the flaky test_poa_multiple_producers test.

Follow-up issue: #2351

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

xgreenx
xgreenx previously approved these changes Oct 14, 2024
@xgreenx xgreenx added the no changelog Skip the CI check of the changelog modification label Oct 14, 2024
AurelienFT
AurelienFT previously approved these changes Oct 14, 2024
@xgreenx
Copy link
Collaborator

xgreenx commented Oct 14, 2024

You can also remove the assert that causes the error below.

image

@xgreenx xgreenx dismissed stale reviews from AurelienFT and themself via c15df60 October 14, 2024 16:41
@rafal-ch rafal-ch marked this pull request as ready for review October 14, 2024 16:43
@xgreenx xgreenx requested a review from AurelienFT October 14, 2024 16:49
@xgreenx xgreenx enabled auto-merge (squash) October 14, 2024 16:49
@@ -209,6 +209,8 @@ mod tests {
// Then
while broadcast_receiver.recv().await.is_ok() {}
assert!(instant.elapsed() >= Duration::from_secs(10));
// Wait for the metrics to be updated.
tokio::time::sleep(Duration::from_secs(1)).await;
Copy link
Member

@rymnc rymnc Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change intended?

@xgreenx xgreenx merged commit 3e212f2 into master Oct 14, 2024
30 of 31 checks passed
@xgreenx xgreenx deleted the disable_flaky_test branch October 14, 2024 17:32
@rafal-ch
Copy link
Contributor Author

You can also remove the assert that causes the error below.
image

I see you merged, but what about this comment? Is this no longer needed due to your changes to crates/services/src/sync_processor.rs?

@xgreenx
Copy link
Collaborator

xgreenx commented Oct 14, 2024

Yeah, I think my change should fix flakyness

@xgreenx xgreenx mentioned this pull request Oct 14, 2024
xgreenx added a commit that referenced this pull request Oct 14, 2024
## Version v0.40.0

### Added
- [2347](#2347): Add GraphQL
complexity histogram to metrics.
- [2350](#2350): Added a new
CLI flag `graphql-number-of-threads` to limit the number of threads used
by the GraphQL service. The default value is `2`, `0` enables the old
behavior.
- [2335](#2335): Added CLI
arguments for configuring GraphQL query costs.

### Fixed
- [2345](#2345): In PoA
increase priority of block creation timer trigger compare to txpool
event management

### Changed
- [2334](#2334): Prepare the
GraphQL service for the switching to `async` methods.
- [2310](#2310): New metrics:
"The gas prices used in a block" (`importer_gas_price_for_block`), "The
total gas used in a block" (`importer_gas_per_block`), "The total fee
(gwei) paid by transactions in a block" (`importer_fee_per_block_gwei`),
"The total number of transactions in a block"
(`importer_transactions_per_block`), P2P metrics for swarm and protocol.
- [2340](#2340): Avoid long
heavy tasks in the GraphQL service by splitting work into batches.
- [2341](#2341): Updated all
pagination queries to work with the async stream instead of the sync
iterator.
- [2350](#2350): Limited the
number of threads used by the GraphQL service.

#### Breaking
- [2310](#2310): The `metrics`
command-line parameter has been replaced with `disable-metrics`. Metrics
are now enabled by default, with the option to disable them entirely or
on a per-module basis.
- [2341](#2341): The maximum
number of processed coins from the `coins_to_spend` query is limited to
`max_inputs`.

## What's Changed
* fix(gas_price_service): service name and unused trait impl by @rymnc
in #2317
* Do not require build of docker images to pass CI by @xgreenx in
#2342
* Prepare the GraphQL service for the switching to `async` methods by
@xgreenx in #2334
* Limited the number of threads used by the GraphQL service by @xgreenx
in #2350
* Increase priority of timer over txpool event by @xgreenx in
#2345
* Disable flaky `test_poa_multiple_producers` test by @rafal-ch in
#2353
* feat: CLI arguments for configuring GraphQL query costs. by @netrome
in #2335
* Add graphql query complexity histogram metric by @AurelienFT in
#2349
* Updated all pagination queries to work with the `Stream` instead of
`Iterator` by @xgreenx in
#2341
* Avoid long heavy tasks in the GraphQL service by @xgreenx in
#2340
* Add more metrics by @rafal-ch in
#2310


**Full Changelog**:
v0.39.0...v0.40.0

---------

Co-authored-by: Rafał Chabowski <rafal.chabowski@fuel.sh>
Co-authored-by: acerone85 <andrea.cerone@gmail.com>
Co-authored-by: rymnc <43716372+rymnc@users.noreply.github.com>
Co-authored-by: Rafał Chabowski <88321181+rafal-ch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants