Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log executor metrics only if enabled in config #2323

Closed
wants to merge 1 commit into from

Conversation

rafal-ch
Copy link
Contributor

@rafal-ch rafal-ch commented Oct 9, 2024

Draft attempt to use "metrics" config param in the executor.

Not sure if this is the way to go because it adds metrics field to ExecutionOptions, which in turn is a member of the versioned InputSerializationType and InputDeserializationType. This could mean a breaking change.


Alternative approach would be to log the metrics in higher layer, ie.: modify the fn produce_inner<TxSource>() to get additional metrics parameter (we have access to Config in all call-sites). Then after either of native_produce_inner() or wasm_produce_inner() finishes, the metric values could be calculated from the ExecutionResult.

@rafal-ch rafal-ch mentioned this pull request Oct 9, 2024
3 tasks
@rafal-ch
Copy link
Contributor Author

rafal-ch commented Oct 9, 2024

Not doing this, will update the metrics in the importer.

@rafal-ch rafal-ch closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant