Added support for PoA key rotation #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # bin/fuel-core/chainspec/local-testnet/state_transition_bytecode.wasm
Dentosal
reviewed
Aug 15, 2024
Dentosal
reviewed
Aug 15, 2024
Dentosal
previously approved these changes
Aug 15, 2024
xgreenx
commented
Aug 15, 2024
| let on_chain_view = combined_database.on_chain().latest_view()?; | ||
|
|
||
| for override_height in poa.get_all_overrides().keys() { | ||
| let block_header = on_chain_view |
There was a problem hiding this comment.
Handle overrides fro mthe future
MitchTurner
approved these changes
Aug 15, 2024
MitchTurner
approved these changes
Aug 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1901
Closes #1919
The
ConsensusConfignow contains one more variant,PoAV2, that also overrides the PoA at specific block heights. It means that starting this block the node expects blocks signed by another PoA key.Along with that, I've added additional features to automate the migration of the state so it is compatible with the new chain configuration:
fuel-corebinary checks if there are any changes in the chain config. If they are, the binary re-inserts the newConesnsus::Genesistype in theSealedBlockConsensustable. Now we can do Updated the chain config's name chain-configuration#1.fuel-coreto react tosigning_key_overrides. If the blocks at the corresponding overwritten block height have different signers, thefuel-corerollbacks to the height before overriding occurs.Side changes:
FuelServiceto be more explicit on the logic.FuelService::TasktoFuelService.Checklist
Before requesting review