Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed comments in the unknown columns PR #2085

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Aug 15, 2024

Addressed comments in the unknown columns PR #2079.

Before requesting review

  • I have reviewed the code myself

@xgreenx xgreenx added the no changelog Skip the CI check of the changelog modification label Aug 15, 2024
@xgreenx xgreenx requested a review from a team August 15, 2024 09:27
@xgreenx xgreenx self-assigned this Aug 15, 2024
@xgreenx xgreenx enabled auto-merge (squash) August 15, 2024 09:27
Copy link
Contributor

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff 👍

@xgreenx xgreenx merged commit cada252 into master Aug 15, 2024
37 of 52 checks passed
@xgreenx xgreenx deleted the feature/address-comments branch August 15, 2024 09:59
@xgreenx xgreenx mentioned this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants