Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): clean up PR template #2077

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

rymnc
Copy link
Member

@rymnc rymnc commented Aug 14, 2024

Makes the PR template look nicer with comments to assist PR creators

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@rymnc rymnc added the no changelog Skip the CI check of the changelog modification label Aug 14, 2024
@rymnc rymnc self-assigned this Aug 14, 2024
Copy link
Contributor

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks better! 👍

@MitchTurner MitchTurner enabled auto-merge (squash) August 14, 2024 12:04
@MitchTurner MitchTurner merged commit 07533b6 into master Aug 14, 2024
58 of 68 checks passed
@MitchTurner MitchTurner deleted the chore/update-pr-template branch August 14, 2024 12:20
@xgreenx xgreenx mentioned this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants