Allow gas price metadata values to be overridden with config #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
previously approved these changes
Aug 8, 2024
| UpdaterMetadata::V0(inner) | ||
| } | ||
| }; | ||
| let inner = new_metadata.into(); |
There was a problem hiding this comment.
I would prefer to use a constructor here instead of into
xgreenx
approved these changes
Aug 9, 2024
Merged
xgreenx
pushed a commit
that referenced
this pull request
Aug 10, 2024
### Added - [2061](#2061): Allow querying filled transaction body from the status. ### Changed - [2067](#2067): Return error from TxPool level if the `BlobId` is known. - [2064](#2064): Allow gas price metadata values to be overridden with config ### Fixes - [2060](#2060): Use `min-gas-price` as a starting point if `start-gas-price` is zero. - [2059](#2059): Remove unwrap that is breaking backwards compatibility - [2063](#2063): Don't use historical view during dry run. ## What's Changed * Bugfix: Remove unwrap in Consensus Param conversion by @MitchTurner in #2059 * Don't use historical view during dry run by @xgreenx in #2063 * Weekly `cargo update` by @github-actions in #2050 * Allow gas price metadata values to be overridden with config by @MitchTurner in #2064 * Use `min-gas-price` as a starting point if `start-gas-price` is zero by @xgreenx in #2060 * Allow querying transaction from the status by @xgreenx in #2061 * Return error from TxPool level if the `BlobId` is known by @xgreenx in #2067 **Full Changelog**: v0.32.0...v0.32.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2065
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]