Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequential relayer's commits #1942

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Jun 6, 2024

Updated relayer to do sequential commits. This means that if we don't have any DA events for height X, we will still insert empty arrays. In most cases, almost every block on DA will contain at least one event, so overhead will be small and only affect the start of the network.

Before requesting review

  • I have reviewed the code myself

@xgreenx xgreenx requested a review from a team June 6, 2024 09:49
@xgreenx xgreenx self-assigned this Jun 6, 2024
Copy link
Member

@MitchTurner MitchTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small question, but other than that it LGTM.

Why do we care if there are some missing blocks? Is this solving for a bug? This isn't connected to an issue.

@@ -210,7 +211,7 @@ impl TestSetupBuilder {

let latest_block = self.starting_block.map(|starting_block| LastBlockConfig {
block_height: starting_block,
state_transition_version: 0,
state_transition_version: LATEST_STATE_TRANSITION_VERSION - 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to the other changes? Why are we pointing to the "old" version here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is not related to the change, just saw in the codebase=D We want to use previous version because after regenesis we want to use a native executor just to speed up tests.

Voxelot
Voxelot previously approved these changes Jun 11, 2024
@xgreenx
Copy link
Collaborator Author

xgreenx commented Jun 11, 2024

Why do we care if there are some missing blocks? Is this solving for a bug? This isn't connected to an issue.

We just want to call the commit function for each separate block to grow blocks one by one and make them connected to each other. It is used by the state rewind feature to create a view of the database at each block height.

@xgreenx xgreenx merged commit 0692cfc into master Jun 11, 2024
33 checks passed
@xgreenx xgreenx deleted the feature/relayer-sequence-commits branch June 11, 2024 15:19
@xgreenx xgreenx mentioned this pull request Jun 14, 2024
xgreenx added a commit that referenced this pull request Jun 14, 2024
## Version v0.29.0

### Added
- [#1889](#1889): Add new
`FuelGasPriceProvider` that receives the gas price algorithm from a
`GasPriceService`

### Changed
- [#1942](#1942): Sequential
relayer's commits.
- [#1952](#1952): Change tip
sorting to ratio between tip and max gas sorting in txpool
- [#1960](#1960): Update
fuel-vm to v0.53.0.

### Fixed
- [#1950](#1950): Fix cursor
`BlockHeight` encoding in `SortedTXCursor`

## What's Changed
* Fix code coverage compilation and tests by @Dentosal in
#1943
* Weekly `cargo update` by @github-actions in
#1949
* Fix cursor block height decoding in SortedTXCursor by @AurelienFT in
#1950
* Sequential relayer's commits by @xgreenx in
#1942
* Add Gas Price Updater Service by @MitchTurner in
#1938
* Change tip sorting to ratio between tip and max gas sorting in txpool
by @AurelienFT in #1952
* deps(client): update eventsource-client to fix CVE(s) by @Br1ght0ne in
#1954
* Update fuel-vm to v0.53.0 by @Dentosal in
#1960

## New Contributors
* @AurelienFT made their first contribution in
#1950

**Full Changelog**:
v0.28.0...v0.29.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants