Remove SpentMessages table

[Dentosal]

Work towards #1790

Depends on #1811

Removes SpentMessages table.

Checklist

• Breaking changes are clearly marked as such in the PR description and changelog
• New behavior is reflected in tests

Before requesting review

• I have reviewed the code myself
• I have created follow-up issues caused by this PR and linked them here

Before merging

• Retarget to master

[Voxelot]

are we removing spent messages due to the extra hassle of regenesis migration? We had that table to provide extra redundancy protection against double spending messages in case of any relayer hiccups. Are we just going to rely on the relayer offchain tables to track included events now? I guess this should be ok, since we pass the events through the executor now instead of letting the relayer directly update the onchain tables.

[xgreenx]

are we removing spent messages due to the extra hassle of regenesis migration? We had that table to provide extra redundancy protection against double spending messages in case of any relayer hiccups. Are we just going to rely on the relayer offchain tables to track included events now?

We added the SpentMessages table for extra redundancy protection against double spending messages because we had two places that can be written into the Messages table. In the past, the relayer inserted new messages into the Messages table, and the executor removed messages from the Messages table.

However, with a new flow, the relayer writes all events into the EventsHistory table, and the executor writes and removes messages from the Messages table while increasing the da height.

The new flow provides the same protection by default because relayer hiccups/pruning no longer affect the Messages table.

[xgreenx]

Ohh, I forgot that it affects the GraphQL API endpoint. Hmm, we need to find a way to still support this endpoint because the bridge relies on it.

Maybe we need to move this table to off-chain database instead.

[Dentosal]

Hmmm in that case I'm probably just going to redo the whole PR.

[xgreenx]

Hmm, this migration even shouldn't exist because we have OldTransactions for that. I think we forgot to remove it during #1811.

Hmm, it seems we need to migrate the ProcessedTransactions table instead of fetching it from OldTransactions because we can't rely on off-chain data during migration. Off-chain data migration is optional and only for nodes that want to support GraphQL API

[Dentosal]

#1811 is not merged yet, so we can still include that there. I'm going to remove this for now, we can do that in a separate PR if not in #1811. Removed in 435d1c6.