Show info about connected peers in the gql api #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
todo:
|
xgreenx
reviewed
Dec 11, 2023
| use super::BlockProducerAdapter; | ||
| #[async_trait::async_trait] | ||
| impl P2pPort for P2PAdapter { | ||
| async fn connected_peers(&self) -> anyhow::Result<Vec<PeerId>> { |
There was a problem hiding this comment.
Hmm, it seems we don't use it. Do we need it?
xgreenx
previously approved these changes
Dec 11, 2023
xgreenx
approved these changes
Dec 11, 2023
xgreenx
pushed a commit
that referenced
this pull request
Dec 11, 2023
Fixes a CI bug introduced in #1524 The latest gql schema wasn't properly committed to the branch and for some reason it wasn't caught in CI until pushed to master. Failing job: https://github.com/FuelLabs/fuel-core/actions/runs/7172572694/job/19530049697
Merged
xgreenx
added a commit
that referenced
this pull request
Dec 12, 2023
## Version v0.22.0 ### Added - [#1515](#1515): Added support of `--version` command for `fuel-core-keygen` binary. - [#1504](#1504): A `Success` or `Failure` variant of `TransactionStatus` returned by a query now contains the associated receipts generated by transaction execution. #### Breaking - [#1531](#1531): Make `fuel-core-executor` `no_std` compatible. It affects the `fuel-core` crate because it uses the `fuel-core-executor` crate. The change is breaking because of moved types. - [#1524](#1524): Adds information about connected peers to the GQL API. ### Changed - [#1517](#1517): Changed default gossip heartbeat interval to 500ms. - [#1520](#1520): Extract `executor` into `fuel-core-executor` crate. ### Fixed #### Breaking - [#1536](#1536): The change fixes the contracts tables to not touch SMT nodes of foreign contracts. Before, it was possible to invalidate the SMT from another contract. It is a breaking change and requires re-calculating the whole state from the beginning with new SMT roots. ## What's Changed * Added support of `--version` command for `fuel-core-keygen` binary by @xgreenx in #1515 * Weekly `cargo update` by @github-actions in #1518 * feat: Add receipts to transaction status by @bvrooman in #1504 * chore: Update gossip heartbeat interval by @bvrooman in #1517 * Weekly `cargo update` by @github-actions in #1525 * Run beta 4 e2e test each 30 minutes by @xgreenx in #1528 * Fix broken link. by @lukema95 in #1526 * Extract executor into fuel-core-executor crate by @Salka1988 in #1520 * Weekly `cargo update` by @github-actions in #1534 * Make `fuel-core-executor` `no_std` compatible by @Salka1988 in #1532 * Fixed contracts tables to touch only own SMT nodes by @xgreenx in #1536 * Show info about connected peers in the gql api by @Voxelot in #1524 * fix committed gql schema by @Voxelot in #1540 ## New Contributors * @lukema95 made their first contribution in #1526 **Full Changelog**: v0.21.0...v0.22.0
Voxelot
added a commit
that referenced
this pull request
Dec 12, 2023
This PR restructures the changes from #1524 to fix an error that would block users from calling `client.chain_info()` without having the p2p feature enabled. While throwing errors on apis that use disabled features is our current convention, it would mean that the sdk testing harness would fail when trying to get the consensus parameters unless it also enabled the p2p feature flag. What changed in this PR: - Information about peers now part of NodeInfo instead of ChainInfo. This seemed like a more suitable location, as chain info relates more towards global network settings and state. NodeInfo on the other hand shows details about the current node instance you've connected to. - Peers are not returned in the default query for NodeInfo, and instead use a special query fragment that's used to only return info about peers. This is beneficial since it will allow users without p2p enabled to still fetch NodeInfo, and also reduce api bandwidth by only returning potentially bulky information about peers through a dedicated api request instead of by default. *Note: This is a release blocker for 0.22 as it will prevent the sdk from working properly*
crypto523
added a commit
to crypto523/fuel-core
that referenced
this pull request
Oct 7, 2024
Fixes a CI bug introduced in FuelLabs/fuel-core#1524 The latest gql schema wasn't properly committed to the branch and for some reason it wasn't caught in CI until pushed to master. Failing job: https://github.com/FuelLabs/fuel-core/actions/runs/7172572694/job/19530049697
crypto523
added a commit
to crypto523/fuel-core
that referenced
this pull request
Oct 7, 2024
## Version v0.22.0 ### Added - [#1515](FuelLabs/fuel-core#1515): Added support of `--version` command for `fuel-core-keygen` binary. - [#1504](FuelLabs/fuel-core#1504): A `Success` or `Failure` variant of `TransactionStatus` returned by a query now contains the associated receipts generated by transaction execution. #### Breaking - [#1531](FuelLabs/fuel-core#1531): Make `fuel-core-executor` `no_std` compatible. It affects the `fuel-core` crate because it uses the `fuel-core-executor` crate. The change is breaking because of moved types. - [#1524](FuelLabs/fuel-core#1524): Adds information about connected peers to the GQL API. ### Changed - [#1517](FuelLabs/fuel-core#1517): Changed default gossip heartbeat interval to 500ms. - [#1520](FuelLabs/fuel-core#1520): Extract `executor` into `fuel-core-executor` crate. ### Fixed #### Breaking - [#1536](FuelLabs/fuel-core#1536): The change fixes the contracts tables to not touch SMT nodes of foreign contracts. Before, it was possible to invalidate the SMT from another contract. It is a breaking change and requires re-calculating the whole state from the beginning with new SMT roots. ## What's Changed * Added support of `--version` command for `fuel-core-keygen` binary by @xgreenx in FuelLabs/fuel-core#1515 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#1518 * feat: Add receipts to transaction status by @bvrooman in FuelLabs/fuel-core#1504 * chore: Update gossip heartbeat interval by @bvrooman in FuelLabs/fuel-core#1517 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#1525 * Run beta 4 e2e test each 30 minutes by @xgreenx in FuelLabs/fuel-core#1528 * Fix broken link. by @lukema95 in FuelLabs/fuel-core#1526 * Extract executor into fuel-core-executor crate by @Salka1988 in FuelLabs/fuel-core#1520 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#1534 * Make `fuel-core-executor` `no_std` compatible by @Salka1988 in FuelLabs/fuel-core#1532 * Fixed contracts tables to touch only own SMT nodes by @xgreenx in FuelLabs/fuel-core#1536 * Show info about connected peers in the gql api by @Voxelot in FuelLabs/fuel-core#1524 * fix committed gql schema by @Voxelot in FuelLabs/fuel-core#1540 ## New Contributors * @lukema95 made their first contribution in FuelLabs/fuel-core#1526 **Full Changelog**: FuelLabs/fuel-core@v0.21.0...v0.22.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #649
Show information about connected peers that may be useful for debugging purposes via the gql api.
Note: in the future it may make sense to protect this API with a special authentication token.