Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is logged when no env is provided, even though it's optional #1360

Closed
Voxelot opened this issue Sep 11, 2023 · 0 comments · Fixed by #1372
Closed

Error is logged when no env is provided, even though it's optional #1360

Voxelot opened this issue Sep 11, 2023 · 0 comments · Fixed by #1372
Assignees
Labels
bug Something isn't working tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.

Comments

@Voxelot
Copy link
Member

Voxelot commented Sep 11, 2023

According to the coding guidelines, we should only use ERROR level if there is a very serious error. https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/logging.md

However, right now we log an error if we can't load the fuel-core settings from an env file even though a user may prefer to use cli args instead. This is a jarring experience for users and we should just remove the logging here.

@Voxelot Voxelot added bug Something isn't working tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. labels Sep 11, 2023
@xgreenx xgreenx self-assigned this Sep 21, 2023
crypto523 pushed a commit to crypto523/fuel-core that referenced this issue Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants