Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual_blocks_enabled only with debug feature enabled during compilation #1297

Closed
xgreenx opened this issue Aug 14, 2023 · 1 comment · Fixed by #1322
Closed

Allow manual_blocks_enabled only with debug feature enabled during compilation #1297

xgreenx opened this issue Aug 14, 2023 · 1 comment · Fixed by #1322
Assignees

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Aug 14, 2023

From the comment: https://github.com/FuelLabs/fuel-core/pull/1286/files#r1290825419

Blocked by #1296

@xgreenx xgreenx self-assigned this Aug 14, 2023
@Voxelot
Copy link
Member

Voxelot commented Aug 22, 2023

As discussed, this should be a cli arg feature flag rather than a compile flag. Otherwise it will impact the ability of the released binaries to be used by sdk harnesses etc.

xgreenx added a commit that referenced this issue Aug 29, 2023
Closes #1297
#1296

Removed `manual_blocks_enabled` flag.
Added a new `debug` flag:
```rust
    /// Should be used for local development only. Enabling debug mode:
    /// - Allows GraphQL Endpoints to arbitrarily advanced blocks.
    /// - Enabled debugger GraphQL Endpoints.
    /// - Allows setting `utxo_validation` to `false`.
    #[arg(long = "debug", env)]
    pub debug: bool,
 ```

Removed `debug` and `dap` features, now the code contains it by default and disables it if `debug` is `false` in the config.

---------

Co-authored-by: Brandon Vrooman <brandon.vrooman@fuel.sh>
crypto523 added a commit to crypto523/fuel-core that referenced this issue Oct 7, 2024
Closes FuelLabs/fuel-core#1297
FuelLabs/fuel-core#1296

Removed `manual_blocks_enabled` flag.
Added a new `debug` flag:
```rust
    /// Should be used for local development only. Enabling debug mode:
    /// - Allows GraphQL Endpoints to arbitrarily advanced blocks.
    /// - Enabled debugger GraphQL Endpoints.
    /// - Allows setting `utxo_validation` to `false`.
    #[arg(long = "debug", env)]
    pub debug: bool,
 ```

Removed `debug` and `dap` features, now the code contains it by default and disables it if `debug` is `false` in the config.

---------

Co-authored-by: Brandon Vrooman <brandon.vrooman@fuel.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants