Wallet already exists warning is not correct #186
Assignees
Labels
bug
Something isn't working
Comments
|
We currently check if the path exists but we want to also check if it is empty. |
Merged
|
addressed by #220 |
zees-dev
added a commit
that referenced
this issue
Oct 30, 2024
# Changelog - added [`tempfile`](https://crates.io/crates/tempfile) to create test dirs for testing - updated test functions and util functions accordingly (removed redundant helper functions and replaced references) - added `rust-toolchain.toml` with stable rust `1.80.0` - minor refactors to CI workflows to match the `rust-toolchain.toml` rust version - git ignoring IDE directory (`.vscode/`) - fixed `new_at_index` function to print checksum wallet address (currently printing bech32 address to stdout) - updated `ensure_no_wallet_exists` function to handle the following cases: - where wallet path is a directory - where wallet path is an empty file - this also addresses: #186 - added unit tests for `ensure_no_wallet_exists` --------- Co-authored-by: Kaya Gokalp <kayagokalp123@gmail.com>
|
I will check and close this if solved it once I am back online which would be on 3rd of November. Thanks a lot for the implementation :) |
|
addressed by #220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried generating a new folder and creating a new wallet at that location. I see that:
warning: There is an existing wallet at ../../wallet. Do you wish to replace it with a new wallet? (y/N)
Which is not possible as the folder is newly created. I think there is an issue about checking the existing wallet.
The text was updated successfully, but these errors were encountered: