Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes - #45 Report reboot for new kernels #83

Merged
merged 1 commit into from
May 16, 2017
Merged

Conversation

sean797
Copy link
Collaborator

@sean797 sean797 commented May 8, 2017

This compares uname -r to the directories in /lib/modules/, if a directory name in /lib/modules/ is bigger than uname -r a fake AffectedApplication is added for it.

@Klaas-
Copy link

Klaas- commented May 8, 2017

I have a question - this would not catch situations in which I explicitly have set grub to not boot newest installed kernel. Is that on purpose?

@sean797
Copy link
Collaborator Author

sean797 commented May 8, 2017

@Klaas- That isn't something I thought about to be honest, but I would say yes its by design.

  • If I have specifically set an old Kernel version to boot, I would still want that reminder. (maybe that's just me? )
  • reading Grub config will likely be fairly complex

You should be able to use the ignore flag in applications.xml https://github.com/FrostyX/tracer/blob/master/data/applications.xml#L36 but i cannot seem to get it to work right now👎

EDIT:
121647f fixes that

@sean797 sean797 force-pushed the kernel branch 2 times, most recently from 716d190 to 30c740b Compare May 8, 2017 14:12
@sean797
Copy link
Collaborator Author

sean797 commented May 8, 2017

Updated so it now respects the ignore flag in applications.xml.
Remember users can also store their own in /etc/tracer/applications.xml & ~/.config/tracer/applications.xml in addition to the one we ship.

@sean797 sean797 changed the title Report reboot for new kernels Fixes - #45 Report reboot for new kernels May 8, 2017
This compares `uname -r` to the directories in /lib/modules/, if a directory name in /lib/modules/ is bigger than `uname -r` a fake AffectedApplication is added for it.
@Klaas-
Copy link

Klaas- commented May 9, 2017

being able to turn if off when I really need to is enough for the usecase, thanks @sean797

@sean797 sean797 merged commit 20f23c6 into FrostyX:master May 16, 2017
@sean797 sean797 deleted the kernel branch May 16, 2017 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants