Improve session detection logic #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process.terminal() returns the path to the terminal attached to the process, if one exists. This will include most processes launched interactively, not just processes that represent sessions. This implements a new heuristic, in which a process is a session if it has a terminal attached and either somehow has no parent or its parent has a different terminal attached. This heuristic is probably not foolproof, but should be sufficient for the majority of cases.
elyscape
force-pushed
the
fix-session-detection
branch
3 times, most recently
from
66ee20e to
cd7288a
Compare
|
Thanks, @elyscape. Agreed - this is a lot better than the current method! ACK 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process.terminal()returns the path to the terminal attached to the process, if one exists. This will include most processes launched interactively, not just processes that represent sessions. This implements a new heuristic, in which a process is a session if it has a terminal attached and either somehow has no parent or its parent has a different terminal attached. This heuristic is probably not foolproof, but should be sufficient for the majority of cases.Fixes #119.