Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-setuptools #183

Closed
sbernhard opened this issue Oct 25, 2021 · 4 comments · Fixed by #185
Closed

python3-setuptools #183

sbernhard opened this issue Oct 25, 2021 · 4 comments · Fixed by #185

Comments

@sbernhard
Copy link
Contributor

Hi,

I wonder, why the python3-setuptools is set as a dependency in the tracer.spec file? I thought, that the setuptools are used to build and distribute python stuff.

Is the setuptools really necessary or can we remove the "Require: python3-setuptools" (and the python2-setupools for pyton2).

Best regards,
Bernhard

CC @jturel

@FrostyX
Copy link
Owner

FrostyX commented Oct 25, 2021

Hello @sbernhard and @jturel,
the python3-setuptools dependency was added in 15ad905
in order to compare version numbers.

We can use some other comparison function if you wish to drop the setuptools dependency.

@jturel
Copy link
Collaborator

jturel commented Oct 25, 2021

Looks like that code has since been refactored and there's not a runtime dependency on setuptools!

@sbernhard
Copy link
Contributor Author

What do you think about using "python packaging"? See documentation https://packaging.pypa.io/en/latest/version.html.

Example: https://thewebdev.info/2021/10/24/how-to-compare-version-numbers-in-python/

Details about the 'python3-packaging' rpm package in centos: https://centos.pkgs.org/8/centos-powertools-x86_64/python3-packaging-16.8-9.el8.noarch.rpm.html

FrostyX added a commit that referenced this issue Oct 27, 2021
Fix #183

It was introduced in 15ad905 in order to compare version numbers,
however the code was reworked and we don't use it anymore.
@FrostyX
Copy link
Owner

FrostyX commented Oct 27, 2021

Looks like that code has since been refactored and there's not a runtime dependency on setuptools!

Ah, I missed that, thank you @jturel.
Please see PR #185

FrostyX added a commit that referenced this issue Oct 30, 2021
Fix #183

It was introduced in 15ad905 in order to compare version numbers,
however the code was reworked and we don't use it anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants