Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple TV+ Not Muting Words #436

Closed
weidjoe opened this issue Sep 8, 2022 · 3 comments
Closed

Apple TV+ Not Muting Words #436

weidjoe opened this issue Sep 8, 2022 · 3 comments
Assignees
Labels
Audio Enhancement New feature or request

Comments

@weidjoe
Copy link

weidjoe commented Sep 8, 2022

_The audio on apple.tv+ is not muting curse words.
I followed instructions provided on #323 but nothing worked

There was no muting on any of the shows or movies provided through apple.tv+

@weidjoe weidjoe added the Enhancement New feature or request label Sep 8, 2022
@richardfrost richardfrost changed the title not muting words Apple T+ Not Muting Words Sep 8, 2022
@richardfrost richardfrost self-assigned this Sep 8, 2022
@richardfrost richardfrost changed the title Apple T+ Not Muting Words Apple TV+ Not Muting Words Sep 8, 2022
@richardfrost
Copy link
Collaborator

@weidjoe thanks for reporting the issue. It looks like there has been a pretty big update to their site's underlying page structure. I've updated the status here and will update this issue when I have more to report.

@richardfrost
Copy link
Collaborator

richardfrost commented Sep 8, 2022

This custom audio config should at least get muting working again:

{
  "tv.apple.com": [
    {
      "mode": "elementChild",
      "parentSelector": "div.video-player div.video-container",
      "showSubtitles": 0,
      "subtitleSelector": ":scope div > div",
      "tagName": "DIV",
      "videoSelector": "div.video-player div.video-container video"
    }
  ]
}

Caveats:

  1. Will only mute the first time seeing the captions/subtitles. If you want to re-watch part of the video with muting, you'll need to refresh the page.
  2. Caption hiding isn't supported and might break filtering.

I will work to fix those remaining items, but wanted to share this in case someone wanted to use it now.

IMPORTANT: Make sure to use "Normal" mode, not "Deep" anymore (more details here).

@richardfrost
Copy link
Collaborator

This should now be fixed in version 2.38.0. For best results, make sure to remove any custom config for Apple TV+ that you may have added previously. This latest version should also handle caption hiding and muting while re-watching.

If you have a chance to test it out, let me know how it goes and if you have any other feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants