Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow issues #225

Closed
Imveryweird opened this issue Jun 24, 2020 · 13 comments
Closed

Overflow issues #225

Imveryweird opened this issue Jun 24, 2020 · 13 comments

Comments

@Imveryweird
Copy link

Sometimes, the profanity filter freezes my browser by going up into the 9,000's and I have to open task manager to even get it to stop.

@richardfrost
Copy link
Collaborator

That sounds like there is some kind of an endless loop. likely a website repeated puts an element on the page with a word to filter, which then gets filtered, and then gets replaced by the website again. It is definitely something that can happen, but if you have any more details it would be helpful to try and pinpoint what is happening.

Do you have a specific site that it happens on? If its reproducible, could you try turning off the counter option and see if it still applies? I'll go ahead and put a cap on the counter (probably 999+).

@Imveryweird
Copy link
Author

Imveryweird commented Jun 24, 2020

Usually it happens in Gutenberg.org when opening a book.
2020-06-24 12 38 34

Edit: turning off the counter did not help.

@richardfrost
Copy link
Collaborator

Is there a specific book that I should test (a link to it would be great)? Is the word (or words if more than one) that is getting filtered in the included/default word list, or one that you added? If it is a word you added, could you share it here so I can test it? If you'd rather, feel free to just export your config and attach it here to this issue.

@Imveryweird
Copy link
Author

Imveryweird commented Jun 24, 2020

Usually it only happens while the page is loading. In Firefox the science fiction section in bookshelves is the worst one. How do I upload my config?

Edit: The words have been: pipe*, wine*, beer*, and cigarette*. The asteriks make it easier for me to see them, and eliminate them to remove the use of alcohol and tobacco.

@richardfrost
Copy link
Collaborator

To share your config, just open the Filter's options page, go to the "Config" tab, and choose "Export". That should give you a .json file with your config that you can upload here.

In the meantime I'll go ahead and get started looking through that page.

@Imveryweird
Copy link
Author

It was the asterik. It kept repeating through the page.

@richardfrost
Copy link
Collaborator

Interesting.. if you would still be willing, I'd like to check your config to try and add some protection to avoid a similar issue in the future.

If you would rather not share your config, could you tell me what the match method of the words are set to?

@Imveryweird
Copy link
Author

I'll see if I can upload the file on my PC. It won't do it on my phone.

@richardfrost
Copy link
Collaborator

Thanks, I'd appreciate it. I still haven't been able to directly reproduce it because I'm not sure of how the words to filter are configured. I have seen similar behavior in the past with substituting a word with another word to filter (which results in an infinite loop), and there are some checks built in to try and prevent that, but its likely they may need to be enhanced based on your findings.

If you have trouble uploading a file, you can also check the "Inline editor" box on the Config tab, and then copy/paste the config into here as just text. Or, if you'd rather, you could go to the options page, then the "Words" tab, select one of those words (like pipe*) and send me a screenshot of the selected options that appear on the page.

@richardfrost
Copy link
Collaborator

@Imveryweird Just wondering if you think you'll have a chance to share either your config or those details on how one of the words was configured so I can try to build in more precautions into the filter. Thanks again for reporting the issue.

@Imveryweird
Copy link
Author

Imveryweird commented Jul 2, 2020

Github would only allow me to upload the zip file.
apf-backup-2020-06-24_124510.zip

@richardfrost
Copy link
Collaborator

Sorry about that, not sure why it would do that. But thank you for sending that over! I will try to add some more protections to prevent that from happening.

@richardfrost
Copy link
Collaborator

This has been added in version 2.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants