-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBO Max #222
Comments
This is a tough one to get all the current features working on it. I prefer using mutation-based rules because they are more timely than a watcher-based rule (check every 20ms). With adding a couple new features to the filter, I was able to get muting to work, but caption hiding is problematic. I don't think there is a way to make it work relying solely on mutations, and as such will probably have to move to a "watcher" mode for that. The issue is that on multi-line captions, each is in its own mutation, so there isn't a good way to know if there is another line coming. For now, I think I'll probably just set it to show all captions/subtitles. If someone is interested in hiding all text, I can give a custom config for that. Its the selective (show only filtered/unfiltered) mode that is problematic. Also, they do some CSS class obfuscation. Currently, tl;dr
|
If anyone has a subscription to HBO Max and would be willing to help test this, I would appreciate it! How to load an unpacked/development extension Pre-release Builds:Now available in Version 2.7.5. |
This is now included in version 2.7.5, but with the same caveat as above (Can't selectively hide or show captions/subtitles). |
I've had a few times now where the muting won't work until I refresh the page. I'm not sure why that's happening, but it might be worth it to add a word like |
For now, it looks like you have to click on "RESET" in the CC/subtitles menu for muting to work. Alternatively, add this to your custom audio config: {
"play.hbomax.com": [
{
"mode": "elementChild",
"parentSelectorAll": "div.class28 > span",
"showSubtitles": 0,
"tagName": "SPAN"
}
]
} If you want to use another CC/subtitle display setting, right now you'll have to find its associated CSS class (like |
I'm curious if anyone could give this new config a try: {
"play.hbomax.com": [
{
"mode": "elementChild",
"parentSelectorAll": "div.class3 > span, div.class28 > span",
"showSubtitles": 0,
"tagName": "SPAN"
}
]
} I don't currently have an account, but I'll try to it when I'm able. |
I can't get the audio muting to work on hbo max. The captions do replacement successfully but no audio mute. |
Hey @erichca, sorry for such a slow response. I thought I replied, but obviously I didn't. Anyway! I appologize that filtering on HBO Max still has some quirkiness. Can you share a screenshot of your caption/subtitle settings on HBO Max? If you would rather, maybe just try pressing the Reset button, and then refresh the page and see if it works. Right now the filter is only working with the defaults/reset config. If you have a specific setup that you'd like to use, let me know and I can probably setup a custom config for you to use. |
Version 2.19.0 changed the method that HBO Max is using. This new mode was designed to handle different subtitle options (where before it needed to be the default, or every once in a while the subtitle settings for HBO Max had to be reset). I had a few people test it with success, but if you try it out, please let me know how it works for you. Thanks! |
🎥 The Site
play.hbomax.com
💬 Subtitle Element/Node
Example:
📝 Additional notes
Requested through the Chrome Web Store support page.
The text was updated successfully, but these errors were encountered: