Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with auto-generated captions #118

Closed
JJRicks opened this issue Feb 12, 2019 · 7 comments
Closed

Compatibility with auto-generated captions #118

JJRicks opened this issue Feb 12, 2019 · 7 comments
Labels
Enhancement New feature or request

Comments

@JJRicks
Copy link

JJRicks commented Feb 12, 2019

Issues are used primarily to track bugs in the project. Feature requests can be submitted either as an issue or here.

Description

Audio muting only currently works with pre-established captions, instead of auto-generated ones. (i.e. YouTube, where the majority of captions are auto generated)

Details (Bugs Only)

Chrome Version:
Extension Version:
Operating System:
Site(s) Affected:

Steps to reproduce (Bugs only)

Other details

Audio muting does however work with auto-generated captions if the user enables them at the exact time when a filtered word is on screen. This would be much more useful if audio is muted only at the time that the word is being spoken, instead of for the entire sentence afterwards, which I believe is possible with auto-generated captions. (the timing works out) I do realize that this is an experimental feature, but I'm quite grateful for it!
Thank you!

Screenshots

@richardfrost
Copy link
Collaborator

Thanks for the creating an issue here! I got your feature suggestion, but its easier to track it here. I will see what I can do. It's a little different than the other subtitles, but it should be possible. Thanks for testing the muting stuff in general, I'm glad you have been getting some use out of it.

@richardfrost
Copy link
Collaborator

Alright, I have released a beta update for Chrome, or I can attach a zip here if you would like to test it. Just let me know which supported browser you would like to try it in. It was quite a bit harder than expected, but I believe I got something to work.

@JJRicks
Copy link
Author

JJRicks commented Feb 14, 2019 via email

@JJRicks
Copy link
Author

JJRicks commented Feb 14, 2019

I'll give it a go in Firefox if I can. :D I've been able to tweak the appearance of captions with the YouTube settings to make them almost invisible; this should be perfect. (Small red font, no background color)

@richardfrost
Copy link
Collaborator

Thanks so much for the donation, I really appreciate it! I have had a lot of fun working on the project, but I love hearing that other's find it useful as well. Here is a Firefox build. If it checks out, I'll go ahead and push a new release. Here are some quick instructions to get it working if you havent: Load Unpacked Extension Info.

extension-firefox.zip

@JJRicks
Copy link
Author

JJRicks commented Feb 14, 2019

Got it installed on a Nightly build, works perfectly! Thanks again, this is fantastic!

@richardfrost
Copy link
Collaborator

Version 2.0.2 has been submitted to the various browser stores.

@richardfrost richardfrost added the Enhancement New feature or request label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants